[CI][Tests] Add BWC tests for 2.4.0#2393
Merged
kavilla merged 1 commit intoopensearch-project:mainfrom Sep 22, 2022
Merged
Conversation
Contributor
|
Do we mean bwc tests for version 2.4.0? (since it's for backward compatibility) |
noCharger
reviewed
Sep 20, 2022
| strategy: | ||
| matrix: | ||
| version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0 ] | ||
| version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0, osd-2.3.0 ] |
Member
Author
There was a problem hiding this comment.
This change is going into main (v2.4.0) for the future changes to be backward compatible with 2.3.0. I see in #2284 1.3.2 was restored into 2.x branch. Do you mean we need to restore 1.3.2 into main?
Member
There was a problem hiding this comment.
Good question yall. For main, it is on version 3.0.0. Via BWC tests we were actually able to realize it is not compatible to migrate directly from 1.x to 3.x which is set by OpenSearch reading which version our indices are from and rejecting the migration. So this helps us keep track and ping doc owners to ensure to note this.
tl;dr: 1.3.2 can't be added to main. Users will have to migrate from 1.x to 2.x to 3.x
manasvinibs
force-pushed
the
bwc-tests-2-3
branch
from
9240c7a to
fd6cd69
Compare
kavilla
added
backport 2.x
test:bwc
ci
v2.4.0
kavilla
previously approved these changes
Sep 20, 2022
manasvinibs
changed the title
Member
Author
Good catch! |
manasvinibs
force-pushed
the
bwc-tests-2-3
branch
from
fd6cd69 to
9a2fd45
Compare
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs
force-pushed
the
bwc-tests-2-3
branch
from
9a2fd45 to
8a5b31b
Compare
kavilla
approved these changes
Sep 21, 2022
ananzh
approved these changes
Sep 22, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2393-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08d05047d125afa7a6f5426de400b1a8b9be62c5
# Push it to GitHub
git push --set-upstream origin backport/backport-2393-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 08d0504)
7 tasks
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 08d0504) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2022
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2022
manasvinibs
added a commit
to manasvinibs/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2022
kavilla
pushed a commit
that referenced
this pull request
Sep 27, 2022
Backport to this PR #2393 Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com
Description
Test data generated with:
yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true
yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true -s true
Issues Resolved
#2230
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr